Add PSR-3 compliant exception context when logging exceptions#300
Open
svenmuennich wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Add PSR-3 compliant exception context when logging exceptions#300svenmuennich wants to merge 1 commit intomodelcontextprotocol:mainfrom
exception context when logging exceptions#300svenmuennich wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
svenmuennich
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
chr-hertel
added
enhancement
chr-hertel
requested changes
May 8, 2026
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Thanks for that impulse @svenmuennich - nice house-keeping. I'd say we could go one step further, WDYT?
Comment on lines
50
to
52
| 'error' => $e->getMessage(), | ||
| 'exception' => $e, | ||
| 'exception_trace' => $e->getTraceAsString(), |
Member
There was a problem hiding this comment.
we can skip the others then I'd guess:
Suggested change
| 'error' => $e->getMessage(), | |
| 'exception' => $e, | |
| 'exception_trace' => $e->getTraceAsString(), | |
| 'exception' => $e, |
Comment on lines
+90
to
92
| 'exception' => $e, | ||
| 'exception_message' => $e->getMessage(), | ||
| 'exception_trace' => $e->getTraceAsString(), |
Member
There was a problem hiding this comment.
Suggested change
| 'exception' => $e, | |
| 'exception_message' => $e->getMessage(), | |
| 'exception_trace' => $e->getTraceAsString(), | |
| 'exception' => $e, |
| $this->logger->info('Session closed', ['session_id' => $this->sessionId]); | ||
| } catch (\Throwable $e) { | ||
| $this->logger->warning('Failed to close session', ['error' => $e->getMessage()]); | ||
| $this->logger->warning('Failed to close session', ['error' => $e->getMessage(), 'exception' => $e]); |
Member
There was a problem hiding this comment.
Suggested change
| $this->logger->warning('Failed to close session', ['error' => $e->getMessage(), 'exception' => $e]); | |
| $this->logger->warning('Failed to close session', ['exception' => $e]); |
chr-hertel
added
needs more work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consistently adds caught exceptions to the logging context as
exception, following the standard defined by PSR-3.Motivation and Context
Previously almost no caught exceptions where included in the context passed to respective PSR logging calls, making it very hard for downstream tooling to e.g. filter certain errors from reporting.
How Has This Been Tested?
Added unit test coverage for inclusion of exceptions in logging.
Breaking Changes
n/a
Types of changes
Checklist
Additional context
I decided to include objects of type
Throwablein the logging, even though PSR-3 only covers objects of typesException. My reasoning was based on the following statement in the spec: